feat(setup-aiengineering): add security review lens 5d to verification gate 5#93
Merged
Merged
Conversation
…n gate 5 Adds a fourth parallel review lens invoking the harness built-in security review (Claude Code: /security-review). Defaults on, deselectable, self-gates on host availability. Triage mirrors 5b: critical/major auto-apply then re-run gates 1-3, minor/info listed for the user. Gate 5 is now count-agnostic, so a deselected 5d needs no conditional rewrite. Adds Step 9b, a suggestion-only nudge for the security-guidance plugin (a separate hooks-only layer, not the source of /security-review), gated on Claude Code + 5d selected + plugin absent. Bumps baseline Skill version v3 -> v4 so re-runs offer both concerns to repos already stamped v3.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a default-on, deselectable security-review lens 5d to gate 5, with capability gating and severity triage. Adds a Claude Code-only, suggestion-only security-guidance plugin offer, updates reporting and baseline tracking, and bumps the skill version to v4. ChangesSecurity Review Lens
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Step4ModuleSelection
participant SKILL.md
participant VerificationProtocol
participant Step9bPluginOffer
Step4ModuleSelection->>SKILL.md: Select security review lens 5d
SKILL.md->>VerificationProtocol: Inject conditional gate 5 lens
VerificationProtocol->>VerificationProtocol: Run or skip security review and merge findings
SKILL.md->>Step9bPluginOffer: Evaluate Claude Code plugin suggestion
Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/security-review). Defaults on, deselectable in the Step 4 module menu, self-gates on host availability. Triage mirrors 5b:critical/majorauto-apply then re-run gates 1-3,minor/infoget listed. Gate 5 covered correctness, general review, and structure, but nothing owned vulnerability classes specifically.security-guidanceplugin, gated on Claude Code + 5d selected + plugin absent. The plugin is a separate hooks-only layer (pattern warnings, LLM diff review on stop, agentic review on commit), not the source of/security-review, which is a Claude Code built-in needing no install. The skill never installs it.Summary by CodeRabbit
New Features
security-guidanceplugin when applicable.Documentation