fix: check for document existence to support React Native#1152
Open
Br1an67 wants to merge 1 commit into
Open
Conversation
c9d8ca2 to
2da7595
Compare
|
|
||
| /** @type {Document|null} */ | ||
| export const doc = isBrowser ? document : null; | ||
| export const doc = isBrowser && typeof document !== 'undefined' ? document : null; |
Owner
There was a problem hiding this comment.
isBrowser should return false in non browser environment. I don't like having this double check "is browser + document is undefined", can you update the isBrowser variable instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1017
Summary
Fixed a ReferenceError that occurred when using anime.js in React Native environments. React Native has a
windowobject but does not have adocumentobject, which caused the library to throw "Property 'document' doesn't exist" error on import.Changes
documentexistence insrc/core/consts.jsbefore accessing itexport const doc = isBrowser ? document : null;toexport const doc = isBrowser && typeof document !== 'undefined' ? document : null;Testing
Verified that the JavaScript parses correctly. This is a minimal, surgical fix that only affects the document detection logic.