fix: the functions updatenodeproperties() and update... in layout.js#1173
Open
orbisai0security wants to merge 27 commits into
Open
fix: the functions updatenodeproperties() and update... in layout.js#1173orbisai0security wants to merge 27 commits into
orbisai0security wants to merge 27 commits into
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
src/layout/layout.js.Vulnerability
V-001src/layout/layout.js:1271Description: The functions updateNodeProperties() and updateNodeTimingParams() in src/layout/layout.js accept externally-supplied property objects (enterFromProps, enterFromTimings) and apply them to animation nodes. If these functions use Object.assign() or direct bracket-notation property assignment without filtering prototype-polluting keys such as 'proto', 'constructor', or 'prototype', an attacker who can control the animation configuration object passed to the anime.js API can inject properties into the global JavaScript Object prototype. This affects every object in the page's JavaScript runtime, not just animation objects.
Changes
src/layout/layout.jsVerification
Automated security fix by OrbisAI Security