Skip to content

Fix utils.set preserving CSS background image URLs#1176

Open
puneetdixit200 wants to merge 1 commit into
juliangarnier:devfrom
puneetdixit200:fix-preserve-css-url-values
Open

Fix utils.set preserving CSS background image URLs#1176
puneetdixit200 wants to merge 1 commit into
juliangarnier:devfrom
puneetdixit200:fix-preserve-css-url-values

Conversation

@puneetdixit200

Copy link
Copy Markdown

Summary

  • preserve url(...) tokens verbatim when decomposing complex CSS strings
  • continue parsing numeric values outside URL tokens for interpolation
  • add a regression test for utils.set() with backgroundImage URLs

Fixes #1154

Tests

  • npm run build
  • focused headless Chrome regression: red before fix, green after fix for utils.set(..., { backgroundImage })
  • focused browser Mocha grep for Set CSS background image URL strings: 1 passing, 0 failing
  • node --input-type=module source parser check for URL tokens and numeric values outside url(...)
  • git diff --check

Local notes

  • npm run test:node has exact V8 optimization-status assertion failures under local Node 24/22.
  • Full headless browser Mocha completed with 594 passes and 5 unrelated engine/draggable/timing/leak failures in this environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant