allow a site theme to include multiple styles - #904
Conversation
essentially concatenate them as a single stream separated with \n\n
❌ Deploy Preview for myst-theme failed. Why did it fail? →Built without sensitive environment variables
|
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the Book and Article themes to support configuring multiple custom CSS files via the style option and loads them in deterministic order.
Changes:
- Marked the
styleoption asmultiple: truein both theme templates. - Updated both themes’
getCustomStyleSheet()to normalizestyleto an array, fetch all styles, and concatenate results in declared order. - Updated common manifest link-rewriting to handle
styleas either a single value or an array.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| themes/book/template.yml | Declares style as a multi-value option and updates its description accordingly. |
| themes/book/app/utils/loaders.server.ts | Loads and concatenates multiple custom stylesheets. |
| themes/article/template.yml | Declares style as a multi-value option and updates its description accordingly. |
| themes/article/app/utils/loaders.server.ts | Loads and concatenates multiple custom stylesheets. |
| packages/common/src/utils.ts | Extends static link rewriting to support array-valued style. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
A few process comments:
|
|
apologies, this now should be better regarding your comments |
implements multiple style clauses in a theme as discussed in
jupyter-book/mystmd#2022
requires jupyter-book/mystmd#2910