Skip to content

Add support for webm format in Picture component video check - #926

Open
goekce wants to merge 2 commits into
jupyter-book:mainfrom
goekce:main
Open

Add support for webm format in Picture component video check#926
goekce wants to merge 2 commits into
jupyter-book:mainfrom
goekce:main

Conversation

@goekce

@goekce goekce commented Jul 10, 2026

Copy link
Copy Markdown

Fixes: jupyter-book/mystmd#2996

Related mystmd component PR: jupyter-book/mystmd#2999

Copilot AI review requested due to automatic review settings July 10, 2026 13:19
@changeset-bot

changeset-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 415b52f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploy Preview for myst-theme failed. Why did it fail? →

Built without sensitive environment variables

Name Link
🔨 Latest commit 415b52f
🔍 Latest deploy log https://app.netlify.com/projects/myst-theme/deploys/6a807b073b7d7e0008233238

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds .webm detection to the Picture component so WebM sources are treated as videos (matching existing .mp4 behavior) in the React renderer.

Changes:

  • Extend the video-source check in Picture to include .webm.
  • Adjust the if condition layout around the video check (introducing a formatting inconsistency that should be cleaned up).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

.avif and .webm extension support

2 participants