Skip to content

Migrate from Denisenkom SQLServer driver to Microsoft#154

Merged
dewey merged 5 commits into
justwatchcom:masterfrom
StuartHadfield:master
Apr 25, 2025
Merged

Migrate from Denisenkom SQLServer driver to Microsoft#154
dewey merged 5 commits into
justwatchcom:masterfrom
StuartHadfield:master

Conversation

@StuartHadfield

@StuartHadfield StuartHadfield commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Denisenkom's sqlserver driver is abandoned (+2y since updates) and was forked by microsoft, who are maintaining it. We should switch to use their driver instead.

@dewey

dewey commented Apr 23, 2025

Copy link
Copy Markdown
Member

@StuartHadfield Thanks, could you run go mod vendor / go mod tidy please then I'll go ahead and merge it.

@StuartHadfield StuartHadfield marked this pull request as draft April 23, 2025 15:42
@StuartHadfield StuartHadfield marked this pull request as ready for review April 23, 2025 16:06
@StuartHadfield

StuartHadfield commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

Hey @dewey, I built this image and tested it and can confirm this now supports kerberos authentication for sqlserver.

@dewey dewey merged commit 4d97970 into justwatchcom:master Apr 25, 2025
1 check passed
@dewey

dewey commented Apr 25, 2025

Copy link
Copy Markdown
Member

Released the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants