Fix black formatting in europarl_st beam_search.py#2098
Conversation
egs/europarl_st/SRT/lcma_srt/beam_search.py (added in k2-fsa#2096) fails the style_check workflow: black 22.3.0 wants to reformat it, which currently turns style_check red for every PR. Reformatted with the same black version CI uses.
There was a problem hiding this comment.
Code Review
This pull request reformats a long line in egs/europarl_st/SRT/lcma_srt/beam_search.py where a TypeError is raised, breaking it into multiple lines to improve code readability. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request reformats the ChangesBeam search validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Heads up for reviewers: the red CI here is unrelated to this PR, which is a formatting-only change to |
csukuangfj
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
egs/europarl_st/SRT/lcma_srt/beam_search.py(added in #2096) fails thestyle_checkworkflow — black 22.3.0 wants to reformat it, so style_check is currently red for every PR (e.g. it's what fails on #2097, whose change is an unrelated shell script).Reformatted with the exact versions the workflow installs (
black==22.3.0,click==8.1.0);black --checkandisort --checkboth pass on the file now. No functional change (+3/-1).Summary by CodeRabbit