whitespace: add \r (windows EOL) to chars#606
Open
msimerson wants to merge 1 commit into
Open
Conversation
Owner
|
Seems straightforward. Could you add a test for this, then I'll merge it? |
Author
|
The test is only going to work correctly on Windows, and a bunch more code changes are required in this repo before windows CI tests pass. I started down that road and its a slog. |
Author
|
related to #581 |
Author
|
likely also related to #522 |
Author
|
and related to #474 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've written a parser using
builtins/whitespaceand the Windows CI tests failed, because the EOL characters are \r instead of \n.