Fixes #9: Validate file size before content type#10
Open
trawick wants to merge 1 commit intokaleidos:masterfrom
Open
Fixes #9: Validate file size before content type#10trawick wants to merge 1 commit intokaleidos:masterfrom
trawick wants to merge 1 commit intokaleidos:masterfrom
Conversation
Aside from the fact that checking size is cheaper, this change fixes a misleading and confusing message described in issue kaleidos#9, where a user uploading a MS Word .doc file which is too big is told incorrectly that the content type is wrong. The tests were changed to work (only) with Django 1.6 and above, which changed humanize to add a non-breaking space (\xa0) between a value and its unit. See this ticket for more details: https://code.djangoproject.com/ticket/20246 I tested with these dependencies along with Python 2.7.6: Django==1.6.11 python-magic==0.4.10
Author
|
The Travis test fails for the same reason my local attempt with Django 1.7 failed: (common migration issue with Django 1.7 -- the Travis setup uses a level of Django with which the base tests fail) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aside from the fact that checking size is cheaper, this change fixes a misleading and confusing message described in issue #9, where a user uploading a MS Word .doc file which is too big is told incorrectly that the content type is wrong.
The tests were changed to work (only) with Django 1.6 and above, which changed humanize to add a non-breaking space (\xa0) between a value and its unit. See this ticket for more
details:
I tested with these dependencies along with Python 2.7.6: