swap mkdir and is_dir in check to prevent php errors#1853
Open
rmpel wants to merge 2 commits intokalessil:masterfrom
Open
swap mkdir and is_dir in check to prevent php errors#1853rmpel wants to merge 2 commits intokalessil:masterfrom
rmpel wants to merge 2 commits intokalessil:masterfrom
Conversation
luukvhoudt
suggested changes
Oct 19, 2022
luukvhoudt
left a comment
luukvhoudt
left a comment
There was a problem hiding this comment.
I guess you forgot to move this = %s thing 😅
...sil/phpStorm/phpInspectionsEA/inspectors/semanticalAnalysis/MkdirRaceConditionInspector.java
Outdated
Show resolved
Hide resolved
...sil/phpStorm/phpInspectionsEA/inspectors/semanticalAnalysis/MkdirRaceConditionInspector.java
Outdated
Show resolved
Hide resolved
...sil/phpStorm/phpInspectionsEA/inspectors/semanticalAnalysis/MkdirRaceConditionInspector.java
Outdated
Show resolved
Hide resolved
...sil/phpStorm/phpInspectionsEA/inspectors/semanticalAnalysis/MkdirRaceConditionInspector.java
Outdated
Show resolved
Hide resolved
...sil/phpStorm/phpInspectionsEA/inspectors/semanticalAnalysis/MkdirRaceConditionInspector.java
Outdated
Show resolved
Hide resolved
Author
|
hehe, don't know ;) as said, I have no way to test it. I'll commit your suggestions, but it is up to the maintainer to test/debug, or someone help me set-up a working compile + test in phpStorm, then I can debug it myself (I hope) |
Co-authored-by: Luuk van Houdt <71889608+luukvhoudt@users.noreply.github.com>
luukvhoudt
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
possible solution for #1847
I THINK this should do it, but, I have no idea how to compile the plugin and use it in phpStorm.
maybe there needs to be some work done around line 120, as that's where another check is for the presence of is_dir is, however; does it check for the position (before or after mkdir) as well???