Open
Conversation
- service status was not being checked during control actions. This allowed for sequences like double start or double stop to proceed when this is likely an error. Also inconsistent with other platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On other platforms, this will return an error. For the sake of consistency we may want to do it here too. It seems like a programmer error for something like a double start or double stop to succeed with a nil error.
The
runrefacotr started in this branch and was incorporated into a separate PR: #287We can either drop it or wait for that and rebase or something.
The
unitFilething can also be squashed, dropped, or left as-is. It predates the other fix but isn't actually important.