Make sure that zombie processes are cleaned up#371
Open
alextoulps wants to merge 1 commit intokardianos:masterfrom
Open
Make sure that zombie processes are cleaned up#371alextoulps wants to merge 1 commit intokardianos:masterfrom
alextoulps wants to merge 1 commit intokardianos:masterfrom
Conversation
Contributor
|
You put it in a wrong place, you should ensure calling Wait only after Start is called without errors |
Author
Yeah was also debating if it should be right after the Start but since it is a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there is a usage of
cmd.Start()ensure that Wait() will be called to clean up resources.Currently in a running app that might poll for the status, this causes a leak.