Skip to content

Make sure that zombie processes are cleaned up#371

Open
alextoulps wants to merge 1 commit intokardianos:masterfrom
alextoulps:fix_zombie_processes
Open

Make sure that zombie processes are cleaned up#371
alextoulps wants to merge 1 commit intokardianos:masterfrom
alextoulps:fix_zombie_processes

Conversation

@alextoulps
Copy link
Copy Markdown

As there is a usage of cmd.Start() ensure that Wait() will be called to clean up resources.
Currently in a running app that might poll for the status, this causes a leak.

@ovoschnoi-salat
Copy link
Copy Markdown
Contributor

You put it in a wrong place, you should ensure calling Wait only after Start is called without errors

@alextoulps
Copy link
Copy Markdown
Author

You put it in a wrong place, you should ensure calling Wait only after Start is called without errors

Yeah was also debating if it should be right after the Start but since it is a defer and the implementation of Wait will in worst case return an error that will be ignored, i wanted to follow the practice of ensuring defer call right after the initialisation of the resource that needs to ensure clean up of resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants