feat(systemd): add WantedBy option with default multi-user.target#415
Open
kongfei605 wants to merge 1 commit intokardianos:masterfrom
Open
feat(systemd): add WantedBy option with default multi-user.target#415kongfei605 wants to merge 1 commit intokardianos:masterfrom
kongfei605 wants to merge 1 commit intokardianos:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When installing a service as a systemd user service (with UserService option set to true), the generated unit file uses WantedBy=multi-user.target by default. However, multi-user.target does not exist in the user systemd instance, which causes the service to fail to start on user login.
Problem
For user services, the correct target should be default.target instead of multi-user.target. Currently, there is no way to customize the WantedBy directive without providing a complete custom systemd script template via the SystemdScript option.
Solution
This PR adds a new WantedBy option that allows users to specify the systemd target:
Default value: multi-user.target (backward compatible)
For user services: users can set it to default.target