Skip to content

Fix workspace deletion from settings#1379

Draft
zajca wants to merge 1 commit into
kdlbs:mainfrom
zajca:zajca/fix-workspace-delete
Draft

Fix workspace deletion from settings#1379
zajca wants to merge 1 commit into
kdlbs:mainfrom
zajca:zajca/fix-workspace-delete

Conversation

@zajca

@zajca zajca commented Jun 15, 2026

Copy link
Copy Markdown

Summary

  • Route Settings workspace deletion through the non-office workspace endpoint so it works when features.office=false.
  • Cascade workspace deletion through workspace-owned tasks and workflows before deleting the workspace row.
  • Add regression coverage for deleting a workspace with task/workflow data.

Root Cause

The Settings delete action called /api/v1/office/workspaces/:id, but production disables Office routes. The legacy /api/v1/workspaces/:id path only deleted the workspace row and did not clean up workspace-owned task/workflow data first.

Verification

  • go test ./internal/task/service -count=1
  • pnpm --filter @kandev/web test -- app/actions/workspaces.test.ts
  • pnpm --filter @kandev/web typecheck

Review in cubic

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a0bf0bc0-87e1-4736-88f2-6833b1b16d8b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@carlosflorencio

Copy link
Copy Markdown
Member

Thanks! approved the ci in both PRs to run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants