Skip to content

Fix GitHub page workspace context#1380

Draft
zajca wants to merge 1 commit into
kdlbs:mainfrom
zajca:zajca/fix-github-workspace-context
Draft

Fix GitHub page workspace context#1380
zajca wants to merge 1 commit into
kdlbs:mainfrom
zajca:zajca/fix-github-workspace-context

Conversation

@zajca

@zajca zajca commented Jun 15, 2026

Copy link
Copy Markdown

Summary

  • Resolve the /github page workspace from URL param, active workspace cookie, saved settings, then first workspace.
  • Hydrate the GitHub page store with the resolved active workspace.
  • Add regression coverage so stale saved settings cannot force the GitHub page back to an older workspace.

Root Cause

The GitHub page resolved workspace context from saved user settings or the first workspace only. It ignored the office-active-workspace cookie used by the sidebar/main page, so clicking the GitHub integration could land users back in the stale Connection workspace.

Verification

  • pnpm --filter @kandev/web test -- app/github/page.test.tsx
  • pnpm --filter @kandev/web typecheck

Review in cubic

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 815a25af-fa10-442b-80de-6914f795007d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant