Skip to content

feat: show OMP advisor feedback#1577

Draft
ClemDNL wants to merge 1 commit into
kdlbs:mainfrom
ClemDNL:feature/show-omp-advisor-fee-uvk
Draft

feat: show OMP advisor feedback#1577
ClemDNL wants to merge 1 commit into
kdlbs:mainfrom
ClemDNL:feature/show-omp-advisor-fee-uvk

Conversation

@ClemDNL

@ClemDNL ClemDNL commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

OMP advisor feedback is visible through ACP as agent-thought metadata and an untyped advisor_feedback session update, so Kandev now preserves that side-channel in the normal session feed instead of making agent replies look one-sided.

Important Changes

  • Normalizes ACP advisor payloads into advisor_feedback stream events before the generic reasoning path so advisor text is not hidden as thinking.
  • Persists advisor feedback as ordinary session-feed messages with advisor metadata, renders them with an OMP Advisor Feedback label, and keeps them visible in message grouping/filtering.

Validation

  • make fmt
  • go test ./internal/agentctl/server/adapter/transport/acp ./internal/integration -run 'TestConvertNotification_AdvisorThoughtChunkMeta|TestTryConvertUntypedUpdate_AdvisorFeedback|TestAdvisorFeedbackEventsPersistToDatabase'
  • pnpm --filter @kandev/web test -- use-processed-messages.test.ts message-renderer.test.ts
  • make build-backend
  • make build-web
  • pnpm --filter @kandev/web e2e -- tests/chat/advisor-feedback.spec.ts
  • make typecheck
  • make lint
  • Full make typecheck test lint was attempted before commit and failed in an existing backend process test (TestProcessRunnerCapturesOutput: process output not captured in time); the targeted advisor tests above passed.
  • Manual live preview on local seeded task confirmed OMP Advisor Feedback and advisor content render in the session feed.

UI

advisor-feedback-preview

Checklist

  • I have performed a self-review of my code.
  • I have manually tested my changes and they work as expected.
  • My changes have tests that cover the new functionality and edge cases.
  • If my change touches UI files (apps/web/), I have added or updated Playwright e2e tests in apps/web/e2e/ and verified them with make test-e2e.

Review in cubic

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ClemDNL ClemDNL force-pushed the feature/show-omp-advisor-fee-uvk branch from 8989d60 to 472c672 Compare July 3, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant