feat: show OMP advisor feedback#1577
Draft
ClemDNL wants to merge 1 commit into
Draft
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8989d60 to
472c672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OMP advisor feedback is visible through ACP as agent-thought metadata and an untyped
advisor_feedbacksession update, so Kandev now preserves that side-channel in the normal session feed instead of making agent replies look one-sided.Important Changes
advisor_feedbackstream events before the generic reasoning path so advisor text is not hidden as thinking.OMP Advisor Feedbacklabel, and keeps them visible in message grouping/filtering.Validation
make fmtgo test ./internal/agentctl/server/adapter/transport/acp ./internal/integration -run 'TestConvertNotification_AdvisorThoughtChunkMeta|TestTryConvertUntypedUpdate_AdvisorFeedback|TestAdvisorFeedbackEventsPersistToDatabase'pnpm --filter @kandev/web test -- use-processed-messages.test.ts message-renderer.test.tsmake build-backendmake build-webpnpm --filter @kandev/web e2e -- tests/chat/advisor-feedback.spec.tsmake typecheckmake lintmake typecheck test lintwas attempted before commit and failed in an existing backend process test (TestProcessRunnerCapturesOutput:process output not captured in time); the targeted advisor tests above passed.OMP Advisor Feedbackand advisor content render in the session feed.UI
Checklist
apps/web/), I have added or updated Playwright e2e tests inapps/web/e2e/and verified them withmake test-e2e.