feat: replace sandboxes-api with editor-service sessions API#88
feat: replace sandboxes-api with editor-service sessions API#88
Conversation
Code reviewFound 2 issues:
Same pattern in:
cli-utils/src/Keboola/Console/Command/EditorServiceClient.php Lines 24 to 28 in 8fe9a50 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
ondrajodas
left a comment
There was a problem hiding this comment.
1 - je to pokaždé jiný use-case, takže v pohodě
2 - to je pravda no, že tímto budeme mazat jen SQL worksapces
|
ad 2. no to není pravda ne? tam byly podmínky Takže to mazalo jen DB workspaces, ne? |
|
no ale když vezmeš celý kus kódu: tak je to mazalo... konkrétně na řádku 116 |
|
A kuš, tak to jsem přehlídl! Tak zpátky do výroby |
|
@ondrajodas Je to nakonec celkem dost předělaný - snažil jsem se to spíš udělat tak, aby to dávalo nějakej smysl než nutně přesně tak jak to bylo předtím :D |
https://linear.app/keboola/issue/AJDA-1942
Description
Replaces all usages of the sandboxes-api PHP client with the editor-service sessions API (SQL workspaces) and the sandboxes-service-api-client (Python/R sandboxes), as the sandboxes API is being turned off. Introduces a lightweight
EditorServiceClientwith list and delete endpoints, adds Python/R sandbox deletion via Job Queue jobs, and removes the now-obsoleteDeleteProjectSandboxescommand.Release Notes
Change Type
Refactoring / internal improvement — migrates from sandboxes-api to editor-service and sandbox-service APIs; adds Python/R sandbox handling to ownerless workspace cleanup commands.
Justification
The sandboxes API is being turned off. SQL workspace sessions are now listed via the editor-service and deleted by removing the associated storage configuration (double-call pattern to purge from trash). Python/R sandboxes are listed via the sandbox-service API and deleted via a Job Queue job of
keboola.sandboxes; if job creation fails, falls back to direct deletion. When a configuration deletion fails (e.g. already in trash in a dev branch), the editor session is also deleted directly to prevent re-listing.Plans for Customer Communication
No customer-facing changes; these are internal maintenance CLI commands.
Impact Analysis
Low risk. Affects three commands (
DeleteOwnerlessWorkspaces,DeleteOrganizationOwnerlessWorkspaces,MassDeleteProjectWorkspaces) and removes one (DeleteProjectSandboxes). No breaking changes to command interfaces. Adds dependency onkeboola/sandboxes-service-api-clientandkeboola/service-client.Deployment Plan
Standard CI/CD continuous deployment across all stacks.
Rollback Plan
Standard git revert if issues detected post-deployment.
Post-Release Support Plan
No follow-up actions needed.