Make the operator gRPC metrics service port configurable#881
Open
somaz94 wants to merge 1 commit into
Open
Conversation
e1cc0a1 to
da75a93
Compare
Signed-off-by: somaz <genius5711@gmail.com>
da75a93 to
e881f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the operator's gRPC Metrics Service port (hardcoded 9666) configurable via a new
operator.metricsServiceTargetPortvalue (default 9666). It wires the existing core--metrics-service-bind-addressflag and updates every reference to the port: the operator args and containerPort, the operator Service, the metrics server--metrics-service-addressconnect arg, and both NetworkPolicies.Resolves #511 (deploying KEDA into restrictive environments that only allow a fixed set of ports, e.g. AKS policy where 9666 is not permitted).
The default stays 9666, so existing installs render identically apart from the now-explicit
--metrics-service-bind-address=:9666arg.Validation (local):
helm templaterender is unchanged except the explicit--metrics-service-bind-address=:9666arg; all ports stay 9666.operator.metricsServiceTargetPort=9777: operator binds:9777, metrics-server logs "Connection to KEDA Metrics Service gRPC server has been successfully established ...:9777", and the external.metrics.k8s.io APIService reports Available.