feat: Expose trigger totals Prometheus metric in the operator pod#3695
Merged
Conversation
3 tasks
v-shenoy
changed the title
tomkerkhove
reviewed
Sep 27, 2022
tomkerkhove
left a comment
tomkerkhove
left a comment
Member
There was a problem hiding this comment.
Can we add e2e tests for this?
Member
if you are talking about tests here, I'd suggest to create x SO/SJ for which you know the triggers and just start scraping the metric. |
Member
|
Let's collaborate on kedacore/charts#316 @v-shenoy |
Contributor
Author
|
/run-e2e prometheus |
Contributor
Author
Added @tomkerkhove @JorTurFer |
zroubalik
reviewed
Sep 27, 2022
tomkerkhove
changed the title
3 tasks
added 6 commits
September 28, 2022 03:03
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
v-shenoy
force-pushed
the
trigger-totals
branch
from
2a7387e to
628ba21
Compare
Contributor
Author
|
Implemented it within the existing controllers. PTAL. @JorTurFer @zroubalik |
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
v-shenoy
force-pushed
the
trigger-totals
branch
from
628ba21 to
558dfdc
Compare
Contributor
Author
|
/run-e2e |
JorTurFer
reviewed
Sep 27, 2022
JorTurFer
left a comment
JorTurFer
left a comment
Member
There was a problem hiding this comment.
Looking good, only one comment inline about e2e test
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Member
|
/run-e2e internal* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes #3663
Relates to kedacore/keda-docs#945, kedacore/charts#317