keda: auto-derive multitenant tenant names from release name#510
Merged
Merged
Conversation
kedifybot
force-pushed
the
agent/keda-mt-autoderive-names
branch
from
0fecb09 to
4e39930
Compare
In multitenant "tenant" mode, the operator name, its ServiceAccount and the operator TLS Secret are suffixed with the Helm release name, so tenants sharing a namespace no longer collide and no longer need manual unique-name overrides. - New helpers in templates/_kedify-helpers.tpl (kept separate from the upstream _helpers.tpl to avoid rebase conflicts): keda.operator.name / keda.operator.serviceAccountName / keda.certificates.secretName. In "tenant" mode they return <value>-<release> (e.g. keda-operator-bar, kedaorg-certs-bar); in default / non-multitenant mode they return the configured value unchanged. - serviceAccount.operator.name now tracks the operator name via the same suffixing. Previously the SA kept the fixed default "keda-operator" even when operator.name was overridden, which is what made a second same-namespace tenant install fail on ServiceAccount ownership. - No values.yaml, values.schema.json or _helpers.tpl changes: defaults stay keda-operator / kedaorg-certs and are read as-is, only suffixed at render time in tenant mode. A tenant now installs with just kedify.multitenant.mode=tenant + watchNamespace. Backward compatible: default and mode=default renders are byte-identical to before (verified with helm template diff across default, cert-manager, network-policy, prometheus, PDB and azure-workload-identity value sets). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kedifybot
force-pushed
the
agent/keda-mt-autoderive-names
branch
from
4e39930 to
1362f92
Compare
wozniakjan
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multitenant
mode: tenant, the operator name, its ServiceAccount and the operator TLS Secret are suffixed with the Helm release name, so tenants sharing a namespace no longer collide and no longer need manual unique-name overrides.templates/_kedify-helpers.tpl(a dedicated file, kept separate from upstream_helpers.tplto avoid rebase conflicts):keda.operator.name/keda.operator.serviceAccountName/keda.certificates.secretName. Intenantmode they return<value>-<release>(e.g.keda-operator-bar,kedaorg-certs-bar); in default / non-multitenant mode they return the configured value unchanged.serviceAccount.operator.namenow tracks the operator name via the same suffixing. Previously the SA kept the fixed defaultkeda-operatoreven whenoperator.namewas overridden — that mismatch is what made a second same-namespace tenant install fail on ServiceAccount ownership.values.yaml,values.schema.jsonor_helpers.tplchanges — those upstream files are untouched. Defaults staykeda-operator/kedaorg-certs, read as-is and only suffixed at render time in tenant mode.kedify.multitenant.mode: tenant+watchNamespace.Backward compatible: default and
mode: defaultrenders are byte-identical to before, verified withhelm templatediffs across default, cert-manager, network-policy, prometheus, PDB and azure-workload-identity value sets.