Modifications to Redetect Fields

[varjolintu]

Noticed that the get_status request after Redetect Fields was not an internal call, but it requested status from KeePassXC that is not even needed here. It is enough to update the page variables and refresh the popup with new data directly.

Other improvements:

• Replace direct calls to page with proper functions.
• Only set username field detected when the content script URL matches the page URL. Otherwise any iframes (from Google etc.) would set the username field detected variable back to false.

Testing strategy

Manually. For example Patreon's login page can be used when Predefined Sites is disabled in the extension settings.

Type of change

• ✅ Refactor (significant modification to existing code)

[varjolintu]

This boolean changes the request to an internal call without sending messages to KeePassXC.

[droidmonkey]

What if the login dialog is in an iframe with a different url and I need to set the username only detection?

[varjolintu]

What if the login dialog is in an iframe with a different url and I need to set the username only detection?

It's valid concern that I also thought about. I need to find a site where I can test this.

EDIT: Found one. Gonna postpone this fix to a later release. Needs some adjustments. Even the version before this PR does not work good enough.