Add support for Creating a new credential manually#2485
Draft
varjolintu wants to merge 3 commits intodevelopfrom
Draft
Add support for Creating a new credential manually#2485varjolintu wants to merge 3 commits intodevelopfrom
varjolintu wants to merge 3 commits intodevelopfrom
Conversation
Member
Author
|
I'd like to merge #2347 before this. KeePassXC side related changes don't have a PR yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new section to the extension popup that allows user to create a new credential manually. It's possible to set a specific group, or use the default when left empty. The new section is available with both unlocked/normal and login popup statuses. A separate database selection input can be added with Protocol V2.
Relevant content script code is moved to background scripts.
Fixes #1234
TODO:
Screenshots or videos
Testing strategy
Manually.
Type of change