Skip to content

Passkeys: Permissions Policy support #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a2kolbasov wants to merge 2 commits into
base: develop
Choose a base branch
from
+18 −4
Open

Passkeys: Permissions Policy support #2862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c5d82c
Passkeys: Permissions Policy support
a2kolbasov Feb 7, 2026
aea8ac5
Add debug logs to `isAllowedByPolicy()`
a2kolbasov Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions keepassxc-browser/content/passkeys-inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ const PASSKEYS_WAIT_FOR_LIFETIMER = 30;
// Apply a script to the page for intercepting Passkeys (WebAuthn) requests
const enablePasskeys = async function() {
const passkeysLogDebug = function(message, extra) {
if (kpxcPasskeysUtils.debugLogging) {
// `global.js` runs at `document_idle`
if (kpxcPasskeysUtils.debugLogging && typeof debugLogMessage === 'function') {
debugLogMessage(message, extra);
}
};
Expand Down Expand Up @@ -63,8 +64,21 @@ const enablePasskeys = async function() {
}
};

const isSameOriginWithAncestors = function () {
/**
* @param {'create' | 'get'} action
* @returns {boolean}
*/
const isAllowedByPolicy = function (action) {
// https://www.w3.org/TR/webauthn-2/#sctn-permissions-policy
const policy = document.featurePolicy || document.permissionsPolicy;
if (policy) {
passkeysLogDebug('Checking Permissions Policy');
return policy.allowsFeature(`publickey-credentials-${action}`);
}

// fallback to sameOriginWithAncestors
try {
passkeysLogDebug('Checking sameOriginWithAncestors');
return window.origin === window.top.origin;
} catch (_err) {
return false;
Expand All @@ -80,14 +94,14 @@ const enablePasskeys = async function() {
if (ev.detail.action === 'passkeys_create') {
const publicKey = kpxcPasskeysUtils.buildCredentialCreationOptions(
ev.detail.publicKey,
isSameOriginWithAncestors(),
isAllowedByPolicy('create'),
);
passkeysLogDebug('Passkey request', publicKey);
await sendResponse('passkeys_register', publicKey);
} else if (ev.detail.action === 'passkeys_get') {
const publicKey = kpxcPasskeysUtils.buildCredentialRequestOptions(
ev.detail.publicKey,
isSameOriginWithAncestors(),
isAllowedByPolicy('get'),
);
passkeysLogDebug('Passkey request', publicKey);
await sendResponse('passkeys_get', publicKey);
Expand Down