Fix filling credentials with readonly username#2954
Open
varjolintu wants to merge 1 commit intodevelopfrom
Open
Fix filling credentials with readonly username#2954varjolintu wants to merge 1 commit intodevelopfrom
varjolintu wants to merge 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases where a password fill is expected, username input field changed to readonly, and the Username Icon is not detected for the password input. Filling from the icon or using popup from the extension toolbar doesn't work.
This fix adds a workaround for the previously unidentified password input to the combination, and performs the fill anyway with both scenarios. Actual detection problem of the password field detection needs a lot more work, and is done separately because many other sites have the same issue.
Refactored some of the code, moving additional checks made during the fill to a separate functions.
Testing strategy
Manually using https://my.uclahealth.org/. No actual account needed to test the site.
Type of change