Support for Safari Web Extension#11702
Closed
sebastianlivoni wants to merge 11 commits intokeepassxreboot:developfrom
Closed
Support for Safari Web Extension#11702sebastianlivoni wants to merge 11 commits intokeepassxreboot:developfrom
sebastianlivoni wants to merge 11 commits intokeepassxreboot:developfrom
Conversation
droidmonkey
added
feature: Browser
pr: new feature
sebastianlivoni
force-pushed
the
feature/safari-web-extension
branch
from
4f1a7e5 to
40b6ea4
Compare
Keychain Access Group is needed on macOS even though application group entitlements
Contributor
Author
|
I've recreated the feature/safari-web-extension branch with the safari web extension embedded within the app. Should I make a new pull request or is it possible to use the recreated branch in this pull request? |
Member
|
@sebastianlivoni Create a new one. |
|
#12002 seems to be the follow-up pr of this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Safari Web Extension (#2443).
The socket path on macOS is changed to
~/Library/Group Containers/org.keepassxc.KeePassXC/KeePassXC.BrowserServerbecause the Safari Web Extension requires the socket to be located within a shared app group.Type of change