Fix missing -D in cmake opts setting#13252
Open
droidmonkey wants to merge 1 commit intodevelopfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Windows release packaging configuration by ensuring the timestamp URL CMake option is passed as a proper -D definition, so CMake actually receives and applies the WITH_XC_CODESIGN_TIMESTAMP_URL setting during signed builds.
Changes:
- Corrected a missing
-Dprefix for theWITH_XC_CODESIGN_TIMESTAMP_URLCMake cache variable in the Windows build path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #13252 +/- ##
===========================================
- Coverage 64.45% 64.45% -0.00%
===========================================
Files 378 378
Lines 39797 39797
===========================================
- Hits 25649 25648 -1
- Misses 14148 14149 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phoerious
approved these changes
Apr 19, 2026
* Bug found using copilot review
4d934e7 to
4e202c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change