added ability to crosscompile using MXE#13261
Open
hax0rbana-adam wants to merge 1 commit intokeepassxreboot:developfrom
Open
added ability to crosscompile using MXE#13261hax0rbana-adam wants to merge 1 commit intokeepassxreboot:developfrom
hax0rbana-adam wants to merge 1 commit intokeepassxreboot:developfrom
Conversation
Member
|
We dont use old style casts, switch them to static_cast please. |
hax0rbana-adam
force-pushed
the
fix-crosscompile
branch
from
698b9c4 to
5f6016e
Compare
droidmonkey
approved these changes
Apr 20, 2026
hax0rbana-adam
force-pushed
the
fix-crosscompile
branch
from
5f6016e to
84931cd
Compare
hax0rbana-adam
force-pushed
the
fix-crosscompile
branch
from
84931cd to
4513de4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling on Windows is case insensitive, so using a capital "W" in Windows.h is fine. However, when cross compiling for Windows, other operating systems require the case to be correct, which prevents this from being compile with MXE.
This change fixes the case of the windows header file in the include statement, and makes some explicit casts to be compatible with MXE.
Testing strategy
Type of change