Skip to content

fix: Docker deploy script exit on error#6286

Merged
shahargl merged 4 commits intokeephq:mainfrom
TubSticks:fix_docker_deploy_script
Apr 24, 2026
Merged

fix: Docker deploy script exit on error#6286
shahargl merged 4 commits intokeephq:mainfrom
TubSticks:fix_docker_deploy_script

Conversation

@TubSticks
Copy link
Copy Markdown
Contributor

@TubSticks TubSticks commented Apr 23, 2026

Closes #6287

📑 Description

The Docker deployment script of Keep does not exit or act when one of the checks fails. For example: it checks whether the folder "state" exists and whether "curl" is installed, but it doesn't act when the exit code is greater than 0. Setting the -e flag in the script solves this and makes sure the script stops when the exit code is 1 or higher.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: TubSticks <45596075+TubSticks@users.noreply.github.com>
Signed-off-by: TubSticks <45596075+TubSticks@users.noreply.github.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 23, 2026

CLA assistant check
All committers have signed the CLA.

Signed-off-by: TubSticks <45596075+TubSticks@users.noreply.github.com>
Signed-off-by: TubSticks <45596075+TubSticks@users.noreply.github.com>
@TubSticks TubSticks marked this pull request as ready for review April 23, 2026 09:13
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. Bug Something isn't working Documentation Improvements or additions to documentation labels Apr 23, 2026
Copy link
Copy Markdown
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 24, 2026
@shahargl shahargl merged commit b2f4226 into keephq:main Apr 24, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

👏 Fantastic work @TubSticks! Your very first PR to keep has been merged! 🎉🥳

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! 🚀

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩‍💻👨‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Docker deploy script doesnt exit when check fails

3 participants