fix: Improve performance for the TreeCommitHistory endpoint by alanpeixinho · Pull Request #1877 · kernelci/dashboard

alanpeixinho · 2026-04-23T21:42:01Z

Summary

Optimize TreeCommitHistory endpoint with improved database queries for better performance
Add new TreeCommitsListView endpoint for future paginated tree commit listing
Update frontend CommitNavigationGraph component and API integration

How to Test

Verify backend endpoints:
- GET /api/tree/{tree_id}/commits-history/ - optimized commit history
- GET /api/tree/{tree_id}/commits-list/ - commit listing
Frontend:
- Navigate to a tree details page
- Verify CommitNavigationGraph renders correctly with commit history for builds, boots and tests.
- Check that commit list view loads properly.
Performance:
- Compare response times for TreeCommitHistory endpoint before/after changes on large trees.

Closes #1883

MarceloRobert

Some filters are not working [in treeDetails]:

test hardware - 0 results
boot origin - not applying
test inconclusive status - missing data
boot inconclusive status - missing data
build inconclusive status - 0 results / missing data
test issue (uncategorized) - 0 results
build issue (real) - 0 results
boot issue (any) - 0 results

I'm also getting error 400 on trees without tree_name or git_branch. Maybe we could just fallback to the old endpoint in those cases.

Also also, the hardwareDetails page requests the commitHistory when there's a single tree selected but it is returning error 400 for me

MarceloRobert · 2026-04-30T13:24:46Z

+    git_branch: Optional[str],
+    tree_name: Optional[str],


tree_name and git_branch can be null but there's no query condition in the query if they are None

My idea was to not apply filtering when not specified, do we have cases, where we want to search specifically for null branchs and tree names?

It's not common but there are cases of trees without name/branch. Ex.: broonie tree, even though the current commitHistory is not right here either, it at least lets the user navigate through the commits

I am adding an option to search for exactly NULL tree names and branches.
What I dislike is that it makes this parameters no longer trully an optional filter, as null is now just another id

That's how we have to work with this database, unfortunately. I think you added the filter to the get_tree_commit_history_hashes_aggregated query but not for the get_tree_commits query

MarceloRobert · 2026-04-30T13:27:44Z

+    if include_boots and not include_tests:
+        boot_filter = "\nAND t.path LIKE 'boot%%'"
+    elif include_tests and not include_boots:
+        boot_filter = "\nAND t.path NOT LIKE 'boot%%'"


the boot filter should be = boot or like boot.%. This is because a test called "bootloader_something" is not considered a boot test, only those with the specific name "boot" or "subtests" of boot

Both conditions should apply at all times, so it should be

if include_boots and not include_tests: boot_filter = "\nAND (t.path ='boot' OR t.path LIKE 'boot.%%')" elif include_tests and not include_boots: boot_filter = "\nAND t.path NOT LIKE 'boot.%%' AND t.path != 'boot'"

You are absolutely right. My oversight.

This change is still missing, no?

Yes, this change was still local. It should have been updated now.

alanpeixinho · 2026-04-30T13:50:44Z

Some filters are not working [in treeDetails]:

test hardware - 0 results

boot origin - not applying

test inconclusive status - missing data

boot inconclusive status - missing data

build inconclusive status - 0 results / missing data

test issue (uncategorized) - 0 results

build issue (real) - 0 results

boot issue (any) - 0 results

I'm also getting error 400 on trees without tree_name or git_branch. Maybe we could just fallback to the old endpoint in those cases.

Also also, the hardwareDetails page requests the commitHistory when there's a single tree selected but it is returning error 400 for me

The 400 returns was a choice for empty cases. Is it preferrable to return 200 and an empty list?

MarceloRobert · 2026-04-30T16:08:49Z

The 400 returns was a choice for empty cases. Is it preferrable to return 200 and an empty list?

For the cases that I have seen the error 400, they should actually be returning data, not be empty. As for when they should be empty, then I guess we have been using status 200 with an error message, but it can be up for debate again; my preference would be the 200 with "error" message (I know it's not a real error but the field in the response is called error)

* Improve query performance for commit history * Add TreeCommitsListView and type models * Update frontend API and CommitNavigationGraph

alanpeixinho force-pushed the fix/improve-commit-history-performance branch 2 times, most recently from bdd01aa to 3c4f037 Compare April 24, 2026 14:58

MarceloRobert assigned alanpeixinho Apr 24, 2026

alanpeixinho force-pushed the fix/improve-commit-history-performance branch from 3c4f037 to a1886f0 Compare April 24, 2026 20:53

MarceloRobert added Backend Most or all of the changes for this issue will be in the backend code. Queries Issue that involves modifying some DB query labels Apr 27, 2026

alanpeixinho force-pushed the fix/improve-commit-history-performance branch 12 times, most recently from c513c76 to 8db039a Compare April 29, 2026 23:58

alanpeixinho marked this pull request as ready for review April 30, 2026 00:02

alanpeixinho force-pushed the fix/improve-commit-history-performance branch 3 times, most recently from ade6703 to 1da2177 Compare April 30, 2026 12:51

MarceloRobert reviewed Apr 30, 2026

View reviewed changes

alanpeixinho force-pushed the fix/improve-commit-history-performance branch 5 times, most recently from 6c5cd08 to 84b21c7 Compare May 5, 2026 23:26

alanpeixinho force-pushed the fix/improve-commit-history-performance branch from 84b21c7 to c2b8765 Compare May 6, 2026 02:06

fix: optimize TreeCommitHistory endpoint and add tree commits list view

f210cf7

* Improve query performance for commit history * Add TreeCommitsListView and type models * Update frontend API and CommitNavigationGraph

alanpeixinho force-pushed the fix/improve-commit-history-performance branch from c2b8765 to f210cf7 Compare May 6, 2026 02:11

Conversation

alanpeixinho commented Apr 23, 2026 • edited by gustavobtflores Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to Test

Uh oh!

MarceloRobert left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gustavobtflores May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alanpeixinho commented Apr 30, 2026

Uh oh!

MarceloRobert commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alanpeixinho commented Apr 23, 2026 •

edited by gustavobtflores

Loading

gustavobtflores May 5, 2026 •

edited

Loading