Updated compatibility for Seurat - #138
Open
aliibarry wants to merge 9 commits into
Open
Conversation
Changed default values for tsne and umap parameters in seuratProcV3 function; full disclosure, didn't test further why tsne failed with Seurat V5, may simply be an edge case.
Contributor
|
Thanks @aliibarry So, basically everything works except the Seurat developers deprecated It's been a while since I have looked at the v5 Seurat tutorials. I suspect you are just running this guide, right? https://satijalab.org/seurat/articles/seurat5_integration Question: Question:
You could provide more details/outputs? That would be helpful for me to debug. Best, Evan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor updates to work with Seurat V5, addressing depreciation of
slotforlayeras discussed in #133Includes additional switch from tsne to umap default when running
basicSeuratProc(); although I never debugged why tsne fails with some Seurat V5 objects.