Add PVC capacity validation - #55
Open
AdyCohen1 wants to merge 1 commit into
Open
Conversation
AdyCohen1
marked this pull request as draft
August 3, 2026 08:38
AdyCohen1
force-pushed
the
test/add-pvc-capacity-validation
branch
from
August 3, 2026 09:33
316eebc to
77ffb1a
Compare
AdyCohen1
marked this pull request as ready for review
August 3, 2026 09:34
noamasu
reviewed
Aug 6, 2026
AdyCohen1
force-pushed
the
test/add-pvc-capacity-validation
branch
from
August 6, 2026 15:47
77ffb1a to
f5be44d
Compare
AdyCohen1
force-pushed
the
test/add-pvc-capacity-validation
branch
from
August 18, 2026 14:18
f5be44d to
d0becb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
The storage checkup does not verify whether the storage provisioner delivers the correct amount of raw storage when a PVC is requested.
After this PR:
The checkup creates a 12345Mi Block-mode PVC and verifies the provisioner delivers at least the requested capacity. If the provisioned capacity is less than requested, the checkup fails. Handles WaitForFirstConsumer StorageClasses via selected-node annotation.
Test plan
Unit tests pass (
pvcCapacityMismatch, happy path, skip when no default SC)Run checkup against Immediate and WFFC StorageClasses; confirm bind + capacity result
Confirm under-provisioned capacity fails the checkup and is reported in
status.result.pvcCapacityReferences
https://redhat.atlassian.net/browse/CNV-94240