fix: Use Kinde without an SDK overhaul#736
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughRewrites and expands the "Use Kinde without an SDK" guide (frontmatter, full quickstart, backend vs SPA/mobile authorization flows with state and PKCE, callback/token exchange, route protection, request-parameter reference, and FAQs) and updates one redirect reference in a related doc. ChangesKinde without SDK Documentation
Redirect link correction
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying kinde-docs-preview with
|
| Latest commit: |
5553e1e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://249aaf5a.kinde-docs-preview.pages.dev |
| Branch Preview URL: | https://tamal-update-use-kinde-witho.kinde-docs-preview.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/content/docs/developer-tools/about/using-kinde-without-an-sdk.mdx`:
- Around line 324-339: Update the "Handling token expiry" section to distinguish
confidential vs public clients: clarify that the provided refresh POST example
(the grant_type=refresh_token request including client_secret) applies to
confidential backend apps, and add a separate note (or alternate example)
stating that SPAs/mobile apps using PKCE do not include client_secret when
exchanging a refresh token; ensure the text references the existing example and
the PKCE flow described earlier so readers know which client type each approach
(with or without client_secret) applies to.
- Around line 633-635: Complete the unfinished sentence under the "Does Kinde
support the Implicit Flow?" heading by appending the reason (e.g., "because it
is considered insecure and has known vulnerabilities") — you can mirror the
wording used earlier in the document (line referencing the earlier statement
that "Kinde does not support the implicit flow as it has shown to be unsecure")
so the final line reads something like: "No, Kinde does not support the Implicit
Flow because it is considered insecure and has known vulnerabilities."
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 39ea6e50-fa81-42ab-a9f1-8261b7bcd859
📒 Files selected for processing (1)
src/content/docs/developer-tools/about/using-kinde-without-an-sdk.mdx
…sdk.mdx Co-authored-by: Victor Eronmosele <victoreronmosele@gmail.com>
This PR does an overhaul to the Use Kinde without an SDK. The doc adds detailed steps on the authorization code flow along with the PKCE flow for SPAs. It includes detailed code examples for users to get started with Kinde without an SDK.
Summary by CodeRabbit
offline), deprecatedstart_page, added FAQs (Implicit Flow not supported; userinfo vs id_token).