update: Applications in Kinde#750
Conversation
Deploying kinde-docs-preview with
|
| Latest commit: |
13e6c5d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4954794d.kinde-docs-preview.pages.dev |
| Branch Preview URL: | https://tamal-update-applications-in.kinde-docs-preview.pages.dev |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (16)
💤 Files with no reviewable changes (1)
WalkthroughThis PR consolidates application documentation by expanding about-applications.mdx with complete app type guidance, Device/IoT flow details, and management instructions, while removing the separate add-and-manage-applications page. Device authorization polling is corrected to 10 minutes. Configuration and cross-document links are updated to point to the new consolidated guide. ChangesDevice flow timing and documentation consolidation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for this — the merge of the two application pages and the new Device & IoT section are solid improvements. A few things to address before merge: Must fix1. Stale
2. The Device & IoT section says to stop polling after 3. The diff reformats a large number of existing redirects (quote style, single-line vs multi-line). Could we revert the formatting-only changes and keep just the new redirect? "/build/applications/add-and-manage-applications/": "/build/applications/about-applications/",That would make this much easier to review and reduce merge conflict risk. 4. Internal links still point to the old URL These 7 pages still link to
5. Stale frontmatter
6. Missing The deleted page had Nits
Overall direction looks good — happy to approve once the metadata and config noise are cleaned up. |
|
All implemented @shafaladhikari |
|
Re-reviewed latest commit. All feedback has been addressed. ✅ |
This PR makes a significant update to the Applications overview page. It merges two pages and adds a redirect to the config.
Summary by CodeRabbit