Skip to content

generateRandomBytes is faulty #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincent-richard merged 2 commits into from
Jul 21, 2025
Merged

generateRandomBytes is faulty #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77ae5d9
posix: avoid having undefined bytes in generateRandomBytes result
jengelh Jul 8, 2025
b4e655d
posix: let generateRandomBytes use the entire char range
jengelh Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/vmime/platforms/posix/posixHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,17 +275,20 @@ shared_ptr <vmime::utility::childProcessFactory> posixHandler::getChildProcessFa
void posixHandler::generateRandomBytes(unsigned char* buffer, const unsigned int count) {

int fd = open("/dev/urandom", O_RDONLY);
ssize_t have = 0;

if (fd != -1) {

read(fd, buffer, count);
have = read(fd, buffer, count);
close(fd);
if (have < 0)
have = 0;

} else { // fallback
}

for (unsigned int i = 0 ; i < count ; ++i) {
buffer[i] = static_cast <unsigned char>(rand() % 255);
}
// fallback
for (unsigned int i = have ; i < count ; ++i) {
buffer[i] = static_cast <unsigned char>(rand() % 256);
}
}

Expand Down