Accept array-typed type keyword in UnmarshalJSON - #5
Closed
ddevcap wants to merge 1 commit into
Closed
Conversation
JSON Schema (draft-07 and 2020-12, validation section 6.1.1) allows the type keyword to be a string or an array of strings, where an instance is valid when its type matches any listed type. UnmarshalJSON decoded the keyword straight into the Type string field, so the array form failed with "cannot unmarshal array into Go struct field". Parse the keyword via json.RawMessage and normalize the array form into the equivalent anyOf branches (wrapped as an allOf member when the schema carries its own anyOf, preserving conjunction).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JSON Schema (draft-07 and 2020-12, validation spec §6.1.1) allows the
typekeyword to be either a string or an array of strings, where an instance validates if its type matches any listed type.Schema.UnmarshalJSONdecodes the keyword straight into theType stringfield, so any spec-valid schema using the array form fails to parse:Fix
UnmarshalJSONnow parses the keyword viajson.RawMessage:Typeas before;anyOfbranches (one{"type": ...}schema per entry). When the schema object already carries its ownanyOf, the type union is wrapped as anallOfmember instead, preserving the conjunctive semantics of sibling keywords (core spec §10.1).The normalization is semantics-preserving:
{"type": ["string","null"]}and{"anyOf": [{"type":"string"},{"type":"null"}]}accept exactly the same instances. Marshalling emits theanyOfform.Covered by three new tests: plain array form, array form alongside an existing
anyOf, and invalidtypevalues still erroring.