Skip to content

Fixing PanelManager error #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuriyevn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing PanelManager error #1

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd91f44
Fixing PanelManager error
nuriyevn Dec 4, 2018
d5c505e
Update main.js
nuriyevn Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ define(function (require, exports, module) {

CommandManager.register('Handling Build', 'builder.build', handle);

KeyBindingManager.addBinding('builder.build', 'Ctrl-Alt-B');
KeyBindingManager.addBinding('builder.build', 'Ctrl-Shift-B');
KeyBindingManager.addBinding('builder.build', 'Ctrl-Shift-N');

@kmashint kmashint Dec 9, 2018

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using OSX? I'm on Windows and Ctrl-Alt-B is the best since Ctrl-Shift-B must be taken for something else. If Ctrl-Shift-B is better for OSX I can check the OS type and switch accordingly.

@nuriyevn nuriyevn Dec 9, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just noticed that I have another plugin which is Called "Brackets Beautify" and ironically it is a single plugin so far and it also uses this shortcut Ctrl-Alt-B to make formatting, so that's not mandatory to accept the key bindings in the commit :)
I use linux (ubuntu)
neither brackets
https://github.com/adobe/brackets/wiki/Brackets-Shortcuts
nor ubuntu
https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts
have predefined Ctrl -Alt - B.
IMHO, what we can do is to set the Key Binding in config.json and then load in course, I think that will be a better decision than OS differentiation, it's to complicated and we can not rely on default scenario.

MacOS
https://support.apple.com/en-us/HT201236
And windows
https://support.microsoft.com/en-ca/help/12445/windows-keyboard-shortcuts

There can be another application which globally override this combination , so we should let the user to choose whatever if default does not work for him(her).



// Add menu item to edit .json file
var menu = Menus.getMenu(Menus.AppMenuBar.EDIT_MENU);
Expand Down