Skip to content

use knative/pkg for minimum k8s version#659

Open
psschwei wants to merge 3 commits into
knative-extensions:mainfrom
psschwei:pkg-version
Open

use knative/pkg for minimum k8s version#659
psschwei wants to merge 3 commits into
knative-extensions:mainfrom
psschwei:pkg-version

Conversation

@psschwei
Copy link
Copy Markdown
Member

@psschwei psschwei commented May 7, 2026

Changes

  • 🧹 use knative/pkg for minimum k8s version
  • 🧹 increases minimum kind version to v0.30
  • 🧹 increases minimum minikube version to v1.37

/kind cleanup

Fixes #644

Release Note

Sources the minimum kubernetes version from knative/pkg, to keep in sync with the 
rest of the project. Also increases minimum kind version to v0.30, and increases minimum 
minikube version to v1.37.

@psschwei psschwei requested a review from dprotaso May 7, 2026 23:53
@knative-prow knative-prow Bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 7, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 7, 2026

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 7, 2026
@knative-prow knative-prow Bot requested a review from dsimansk May 7, 2026 23:56
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 7, 2026

There are empty aliases in OWNER_ALIASES, cleanup is advised.

psschwei added 2 commits May 7, 2026 21:32
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@dprotaso
Copy link
Copy Markdown
Contributor

dprotaso commented May 8, 2026

what's pulling in all these deps now?

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@psschwei
Copy link
Copy Markdown
Member Author

psschwei commented May 8, 2026

what's pulling in all these deps now?

adding pkg

But the CI was failing because of some issue with a hashicorp package that somehow got added back when client-pkg was archived... I dropped it and now we're all green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We should know what mind version Knative requires and use that for the kind/minikube version

2 participants