Skip to content

HW Python - Saar Cohen #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaarCohen93 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

HW Python - Saar Cohen #11

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24093dd
Homework1
SaarCohen93 Nov 30, 2019
823e75b
Fixed-HW
SaarCohen93 Dec 1, 2019
70b7c4a
fixed2
SaarCohen93 Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions Python-Home-Challenges/recurring word.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@

where_file = input('Enter the file route: ')
my_file = open(where_file,"r")
print("Your file text is:")
for x in my_file:
print(x)
print("---------------")
words_in_text = dict()
my_file = open(where_file,"r")
Copy link
Copy Markdown
Contributor

@AviadP AviadP Dec 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont need to open file again, also, file must be closed after ward. best practice is to use "open...with" when working with files.

Copy link
Copy Markdown
Author

@SaarCohen93 SaarCohen93 Dec 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roger that!
will be fixed.

Copy link
Copy Markdown
Contributor

@AviadP AviadP Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont need to open file again

Copy link
Copy Markdown
Author

@SaarCohen93 SaarCohen93 Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix.
strange, i was sure that i removed it.

for line in my_file:
Expand All @@ -18,5 +14,10 @@
for key in list(words_in_text.keys()):
print(key, ":", words_in_text[key])
print("---------------")
print (max(words_in_text.values()))

max1=0
for highest in list(words_in_text.keys()):
if max1 < words_in_text[highest]:
max1 = words_in_text[highest]
key1 = highest
print ("The most recurring word is: ", key1," with ",max1, " times")
Copy link
Copy Markdown
Contributor

@AviadP AviadP Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is much better to use f' string. easier to read your code

Copy link
Copy Markdown
Author

@SaarCohen93 SaarCohen93 Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

my_file.close()
Copy link
Copy Markdown
Contributor

@AviadP AviadP Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should close file as soon as you done with reading it, or better - use "with...open..."

Copy link
Copy Markdown
Author

@SaarCohen93 SaarCohen93 Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to with open.