Skip to content

Python challenge- HW #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morbitton wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Python challenge- HW #15

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
602aab6
Python Hw
morbitton Dec 3, 2019
b0dc4db
text file
morbitton Dec 3, 2019
7dc2be2
homework python
morbitton Dec 3, 2019
441f213
fix homework python
morbitton Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions HW python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#my code:

with open('text.txt') as file:
Copy link
Copy Markdown
Contributor

@AviadP AviadP Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with...open... context should only include file operation

Copy link
Copy Markdown
Author

@morbitton morbitton Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AviadP I changed the file mode - read mode

Copy link
Copy Markdown
Contributor

@AviadP AviadP Dec 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use "with..open..." context manager, as explained in class

Copy link
Copy Markdown
Author

@morbitton morbitton Dec 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AviadP i change at the new file to - with open('text.txt', 'r') as file

List=file.read().split()
Comment thread
morbitton marked this conversation as resolved.
Outdated
wordDict={}
Copy link
Copy Markdown
Contributor

@AviadP AviadP Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz follow python style guide for variable names = this one should be "word_dict", but anyway try to chose better variable names, something that describe the purpose of this var

Copy link
Copy Markdown
Author

@morbitton morbitton Dec 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AviadP I renamed it meaningful - word_counter
and in the second problem i renamed to f_read instead of List

for word in List:
if word in wordDict:
wordDict[word]+=1
else:
wordDict[word]=1

print(f' the most recurring word in that file: {max(wordDict, key=wordDict.get)}')
print(f'Appears {wordDict[max(wordDict,key=wordDict.get)]} times')