Skip to content

Coding challenge 0.1 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yarinh55 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Coding challenge 0.1 #8

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3adfa5
Adding Yarin_Solution file
Yarinh55 Nov 28, 2019
98f6be4
test
Yarinh55 Nov 28, 2019
601f6d9
Adding Yarin_solution file
Yarinh55 Nov 28, 2019
8873316
fixed solution after review
Yarinh55 Dec 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions Python-Home-Challenges/Yarin_solution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@

def most_common_word(file_name):
Copy link
Copy Markdown
Contributor

@AviadP AviadP Nov 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for using functions
but, best practice, is to create few functions, with each one of them doing 1 thing only

words_dict={}
with open(file_name) as file:
data_set=file.read()
split_it= data_set.split()
for word in split_it:
if word in words_dict.keys():
words_dict[word]+=1
else:
words_dict.update({word:1})
maximum = max(words_dict, key=words_dict.get)
print(maximum, words_dict[maximum])



if __name__== "__main__":
file_name = input("insert file path: ")
Copy link
Copy Markdown
Contributor

@AviadP AviadP Nov 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a bit risky to ask user to enter file name, if your decision is to do so, you man want to use some validation for his input

most_common_word(file_name)


Copy link
Copy Markdown
Contributor

@AviadP AviadP Nov 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure you code pass Flask8 lint validation