Fix reload#178
Closed
nastya wants to merge 3 commits into
Closed
Conversation
added 3 commits
January 14, 2026 15:33
1) Turn synchronising keys into a batch operation 2) Do not apply new changes to shared metrics dict unless current worker state is fully synchronised with shared dict.
Add lock from lua-resty-lock to organize it. Also return 503 http code when collecting metrics before first sync finished. See REDMINE-13677
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make first sync after load a critical section. Fix nginx hanging on reload due to all workers syncing simultaneously.
Add lock from lua-resty-lock to organize it.
Also return 503 http code when collecting metrics before first sync finished.