Skip to content

fix(workflow): remove execute policy restriction for template delta #4963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leozhang2018 merged 1 commit into from
Sep 2, 2026
Merged

fix(workflow): remove execute policy restriction for template delta #4963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions pkg/microservice/aslan/core/workflow/service/workflow/workflow_template_binding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,45 +582,9 @@ func validateFrontendWorkflowDelta(base *commonmodels.WorkflowV4, patches []*com
}
rendered = next
}
if err := validateJobExecutePolicies(base, rendered); err != nil {
return nil, nil, err
}
return patches, rendered, nil
}

func validateJobExecutePolicies(template, rendered *commonmodels.WorkflowV4) error {
renderedJobs := make(map[string]*commonmodels.Job)
for _, stage := range rendered.Stages {
if stage == nil {
continue
}
for _, job := range stage.Jobs {
if job != nil {
renderedJobs[job.Name] = job
}
}
}

for _, stage := range template.Stages {
if stage == nil {
continue
}
for _, templateJob := range stage.Jobs {
if templateJob == nil {
continue
}
renderedJob, ok := renderedJobs[templateJob.Name]
if !ok {
continue
}
if !reflect.DeepEqual(templateJob.ExecutePolicy, renderedJob.ExecutePolicy) {
return fmt.Errorf("job %q execute_policy must be consistent with workflow template", templateJob.Name)
}
}
}
return nil
}

func validateTemplateBindingPatch(patch *commonmodels.JSONPatchOperation) error {
if patch == nil {
return fmt.Errorf("nil json patch operation")
Expand Down
Loading