Skip to content

Show resolved semantic versions in the renderStatus#4461

Merged
liamfallon merged 2 commits intokptdev:mainfrom
Nordix:show-semantic-versions-in-render-status
Apr 8, 2026
Merged

Show resolved semantic versions in the renderStatus#4461
liamfallon merged 2 commits intokptdev:mainfrom
Nordix:show-semantic-versions-in-render-status

Conversation

@aravindtga
Copy link
Copy Markdown
Contributor

Summary

The renderStatus.mutationSteps[].image field was recording short/unresolved image names instead of fully qualified ones. This PR fixes that by moving tag resolution from ContainerFn.Run() to NewRunner(), so f.Image is fully resolved before being captured in RenderStatus.

Changes

  • internal/fnruntime/runner.go - Move tag resolution to NewRunner()
  • internal/fnruntime/container.go - Remove Tag field and resolution logic
  • internal/util/render/executor.go - Minor cleanup in fnChain()

Testing

  • E2E tests are updated

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 2, 2026

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit f826c53
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/69ce7e8b804d5d00081d081a
😎 Deploy Preview https://deploy-preview-4461--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aravindtga aravindtga marked this pull request as ready for review April 2, 2026 08:37
@aravindtga aravindtga requested a review from liamfallon as a code owner April 2, 2026 08:37
Copilot AI review requested due to automatic review settings April 2, 2026 08:37
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. area/fn-runtime KRM function runtime go Pull requests that update Go code labels Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures renderStatus.mutationSteps[].image records fully-qualified/resolved function image references (including semantic-version tag resolution) by performing image/tag resolution earlier during runner construction.

Changes:

  • Resolve function image tags in fnruntime.NewRunner() so the resolved image is available when RenderStatus is captured.
  • Remove Tag handling from ContainerFn since resolution no longer happens at execution time.
  • Minor cleanup in render executor fnChain() to pass the slice element pointer to NewRunner().

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/fnruntime/runner.go Moves tag resolution into NewRunner() so resolved image is available for status capture.
internal/fnruntime/container.go Removes Tag field and execution-time tag resolution from ContainerFn.
internal/util/render/executor.go Updates fnChain() to pass &fns[i], allowing resolved image to propagate to step capture.
pkg/api/kptfile/v1/types.go Formatting-only alignment in ResultItem struct fields.
pkg/test/runner/runner.go Removes stray whitespace line in test runner.
e2e/testdata/fn-render/short-image-path/.expected/diff.patch Updates golden output to expect fully-qualified images in RenderStatus.
e2e/testdata/fn-render/krm-check-exclude-kustomize/.expected/diff.patch Updates golden output to expect fully-qualified images in RenderStatus.
e2e/testdata/fn-render/basicpipeline-semver/.expected/diff.patch Updates golden output to expect resolved semantic-version tags in RenderStatus.
Comments suppressed due to low confidence (1)

internal/fnruntime/container.go:87

  • Typo in comment: "timeour" should be "timeout".
	// Container function will be killed after this timeour.
	// The default value is 5 minutes.
	Timeout time.Duration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm label Apr 2, 2026
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
@aravindtga aravindtga force-pushed the show-semantic-versions-in-render-status branch from 25fef23 to bd8e678 Compare April 2, 2026 14:29
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 2, 2026
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
Copilot AI review requested due to automatic review settings April 2, 2026 14:34
@aravindtga aravindtga force-pushed the show-semantic-versions-in-render-status branch from bd8e678 to f826c53 Compare April 2, 2026 14:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liamfallon liamfallon merged commit db88451 into kptdev:main Apr 8, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/fn-runtime KRM function runtime go Pull requests that update Go code lgtm size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants