Show resolved semantic versions in the renderStatus#4461
Show resolved semantic versions in the renderStatus#4461liamfallon merged 2 commits intokptdev:mainfrom
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR ensures renderStatus.mutationSteps[].image records fully-qualified/resolved function image references (including semantic-version tag resolution) by performing image/tag resolution earlier during runner construction.
Changes:
- Resolve function image tags in
fnruntime.NewRunner()so the resolved image is available when RenderStatus is captured. - Remove
Taghandling fromContainerFnsince resolution no longer happens at execution time. - Minor cleanup in render executor
fnChain()to pass the slice element pointer toNewRunner().
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
internal/fnruntime/runner.go |
Moves tag resolution into NewRunner() so resolved image is available for status capture. |
internal/fnruntime/container.go |
Removes Tag field and execution-time tag resolution from ContainerFn. |
internal/util/render/executor.go |
Updates fnChain() to pass &fns[i], allowing resolved image to propagate to step capture. |
pkg/api/kptfile/v1/types.go |
Formatting-only alignment in ResultItem struct fields. |
pkg/test/runner/runner.go |
Removes stray whitespace line in test runner. |
e2e/testdata/fn-render/short-image-path/.expected/diff.patch |
Updates golden output to expect fully-qualified images in RenderStatus. |
e2e/testdata/fn-render/krm-check-exclude-kustomize/.expected/diff.patch |
Updates golden output to expect fully-qualified images in RenderStatus. |
e2e/testdata/fn-render/basicpipeline-semver/.expected/diff.patch |
Updates golden output to expect resolved semantic-version tags in RenderStatus. |
Comments suppressed due to low confidence (1)
internal/fnruntime/container.go:87
- Typo in comment: "timeour" should be "timeout".
// Container function will be killed after this timeour.
// The default value is 5 minutes.
Timeout time.Duration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
25fef23 to
bd8e678
Compare
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
bd8e678 to
f826c53
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
The
renderStatus.mutationSteps[].imagefield was recording short/unresolved image names instead of fully qualified ones. This PR fixes that by moving tag resolution fromContainerFn.Run()toNewRunner(), sof.Imageis fully resolved before being captured in RenderStatus.Changes
NewRunner()fnChain()Testing