fix parser EOF after calls with trailing whitespace - #6
Open
alogic0 wants to merge 1 commit into
Open
Conversation
Return cleanly when tokenization reaches EOF from the terminal after-call state, and cover common trailing whitespace plus nested calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a parser panic when a completed call is followed by trailing whitespace.
After returning the final
applynode, a subsequentParser.nextcall could consume trailing whitespace and reach EOF while in theafter_callstate. The parser then attempted tocalculate the length of an uninitialized path location, causing an integer overflow in Debug builds.
Fix
Return
nullwhen EOF is reached in the terminalafter_callstate with no outstanding call depth.Tests
Added regression coverage for:
The test suite passes in Debug and ReleaseSafe modes.