fix: setup-claude config filename/key, remove stale tools, bundle sch…#25
Closed
le-dawg wants to merge 2 commits into
Closed
fix: setup-claude config filename/key, remove stale tools, bundle sch…#25le-dawg wants to merge 2 commits into
le-dawg wants to merge 2 commits into
Conversation
…ema in package - setup-claude now writes .mcp.json (not .claude-mcp-config.json) - top-level key changed from 'servers' to 'mcpServers' (Claude Code standard) - removed hardcoded stale tools array and description field from generated config - moved schemas/adr.schema.json into adr_kit/schemas/ for pip distribution - fixed validate.py _get_default_schema_path() to use package-relative path - added [tool.setuptools.package-data] to pyproject.toml - updated tests/unit/test_adr_schema.py path after schema move - added tests/integration/test_setup_commands.py (4 tests, all passing) Fixes: kschlt#23, kschlt#24
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Owner
|
Thanks for this, and for the four issues alongside it — the diagnosis was correct on both counts, and I verified both bugs are still live on
Your I've landed your fix as #30, with your commit credited via
That dependency drift is a real problem on our side and I've filed it separately. Closing this in favour of #30 — the production code there is yours, unchanged. Issues #24, #26 and #27 are untouched by #30 and remain open; they're going to the top of the queue next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ema in package
Fixes: #23
Note: this PR does NOT fix #24 (adr_approve parallel MCP calls auto-rejected by
Claude Code permission prompts). That is a client-side concurrency issue, untouched
here — the only contact with it is removing "adr_approve" from the stale hardcoded
tools array. The original "Fixes #24" claim was corrected so merging this does not
silently auto-close a live bug.