Hide Empty Category if nothing is inside of the category#2603
Open
Philip-Carneiro wants to merge 4 commits intokubeflow:mainfrom
Open
Hide Empty Category if nothing is inside of the category#2603Philip-Carneiro wants to merge 4 commits intokubeflow:mainfrom
Philip-Carneiro wants to merge 4 commits intokubeflow:mainfrom
Conversation
Contributor
YuliaKrimerman
left a comment
There was a problem hiding this comment.
Couple of small things here
b6b33d9 to
3732763
Compare
Contributor
|
/retest |
ppadti
suggested changes
Apr 29, 2026
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
3732763 to
15e17a7
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add changes to hide categories:
Before the changes:
After the changes:
How Has This Been Tested?
It was manually tested.
To test it manually, need to edit the file
clients/ui/bff/internal/mocks/static_data_mock.goAdding this as part of the return object of method
func GetCatalogSourceMocks() []models.CatalogSource {Adding this as part of the return object of method
func GetCatalogLabelListMock() models.CatalogLabelList {Adding this as part of the return object of method
func GetMcpServerCatalogSourceMocks() []models.CatalogSource {Adding this as part of the return object of method
GetMcpServerCatalogLabelListMock() models.CatalogLabelList {Run it
make build; make run;from bff directory.Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes