Fix km-tab label regression introduced by #8049#8059
Open
KhizerRehan wants to merge 1 commit intokubermatic:mainfrom
Open
Fix km-tab label regression introduced by #8049#8059KhizerRehan wants to merge 1 commit intokubermatic:mainfrom
KhizerRehan wants to merge 1 commit intokubermatic:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
I could have reverted #8049 PR but IMO, directive approach is still better as it would help incase Angular migrations run. There won't be issue due to duplicate names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the regression introduced by #8049 that broke the Clusters Overview page by causing the label-template content query to capture unrelated TemplateRef instances produced by structural directives inside the tab body (e.g. *matHeaderCellDef from mat-table).
Why It Broke
@ContentChild(TemplateRef) matches the first TemplateRef instance in projected content. Angular structural directives such as
*matHeaderCellDef, *matCellDef, *matRowDef, *ngIf,etc. desugar to and produce TemplateRef instances.Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind bug
/kind regression
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation:
Test issue: