fix: include node events with null involvedObject.uid in describe output#138362
fix: include node events with null involvedObject.uid in describe output#138362vigneshakaviki wants to merge 1 commit intokubernetes:masterfrom
Conversation
kubectl describe node omits events where involvedObject.uid is unset/null. This happens with kubelet-emitted node status events on some clusters (e.g. EKS). NodeDescriber.Describe() searched for events using two UIDs: 1. The node's real UID (for controller events) 2. The node name as UID (for kubelet events using name workaround) Neither matched events where involvedObject.uid is null/empty. Add a third search with empty UID (matching by kind+name only) and deduplicate the merged results to avoid showing duplicates. Ref: kubernetes/kubectl/issues/1838 Signed-off-by: vigneshakaviki <kumarvignesh295@gmail.com>
|
Please note that we're already in Code Freeze for the upcoming v1.36.0 release. Adding the milestone to this PR is strictly prohibited without proper approval. If this PR needs to be included in the v1.36.0 release:
We're also in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Apr 13 20:20:51 UTC 2026. |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @vigneshakaviki! |
|
Hi @vigneshakaviki. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vigneshakaviki The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/sig cli
What this PR does / why we need it
kubectl describe nodeomits events whereinvolvedObject.uidis unset/null. This happens with kubelet-emitted node status events on some clusters (e.g. EKS), where kubelet creates events withinvolvedObject.uid: nullbut validinvolvedObject.kind=NodeandinvolvedObject.name=<node>.Currently
NodeDescriber.Describe()searches for events using two UIDs:Neither matches events where
involvedObject.uidis null/empty.How does this PR fix it
Adds a third search with empty UID (matching by kind+name only) and deduplicates the merged results using event UIDs to avoid showing duplicate entries.
Verified end-to-end on a local minikube cluster
Stock kubectl — event with null UID is missing from
describe nodeoutput.Patched kubectl — event with null UID correctly appears.
See detailed test results in kubernetes/kubectl/pull/1840 (closed per @soltysh's direction to open here instead).
Which issue(s) this PR fixes
Ref: kubernetes/kubectl/issues/1838
Does this PR introduce a user-facing change?