Skip to content

release-notes: Add custom regex option#4272

Open
damemi wants to merge 1 commit into
kubernetes:masterfrom
damemi:release-notes-custom-regex
Open

release-notes: Add custom regex option#4272
damemi wants to merge 1 commit into
kubernetes:masterfrom
damemi:release-notes-custom-regex

Conversation

@damemi
Copy link
Copy Markdown
Member

@damemi damemi commented Feb 12, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds an option to define a custom release-note block for the release-notes tool

This tool is great and easily adapted to our own project outside of k8s. We would just like to have a stricter regex than the 4 existing defaults. We saw that just blank code blocks in PR descriptions were also matching as release notes.

Understandable if this isn't meant to be used outside of kubernetes, but I figured this change could be useful in the future here too.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add --release-note-regex flag to release-notes tool to define custom regex pattern for release notes.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/release-eng Issues or PRs related to the Release Engineering subproject needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damemi
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 12, 2026
@damemi damemi force-pushed the release-notes-custom-regex branch from e473b7c to 1e0d5ea Compare February 12, 2026 15:36
@damemi damemi mentioned this pull request Feb 16, 2026
Merged
@damemi
Copy link
Copy Markdown
Member Author

damemi commented Feb 26, 2026

bump @jimangel or @jrsapi could you ptal?

damemi added a commit to odigos-io/odigos that referenced this pull request Mar 3, 2026
@damemi
CORE-599: Generate release notes on release from PRs (#4255)
23536e5 
#### What this PR does / why we need it:
From #4232 and
odigos-io/odigos-enterprise#2245, this updates
the release job to generate the release notes and update the github
release with those notes. Currently uses a fork of the k8s release-notes
tool to include the change from
kubernetes/release#4272

#### Changelog entry: Does this PR introduce a user-facing bug fix,
feature, dependency update, or breaking change??
<!--
This section will go in the release notes for this version. Is this
something users should be able to find easily?
If no, just write "NONE" in the release-note block below.
If yes, please add a release note in the block below describing this in
1-2 sentences for our changelog.
-->

```release-note
NONE
```
@damemi damemi mentioned this pull request Mar 4, 2026
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 6, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Jun 4, 2026

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@jrsapi jrsapi Awaiting requested review from jrsapi

Assignees

No one assigned

Labels

area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@damemi @k8s-ci-robot @k8s-triage-robot